fix defaultInitialSearch (#1561)

Prior to this change, if you didn't have a businessId, searches on page load
would error out because a search impression analytics event would try to be fired
using a null analytics reporter service.

J=SLAP-1616
TEST=manual,auto

I can run default initial searches, and searches using the query url param again, in my local
SDK test site and also the theme's test-site

tweaked the universalinitialsearch acceptance suite to not have a business id

src/answers-search-bar.js

@@ -215,11 +215,13 @@ class AnswersSearchBar {
     this._handlePonyfillCssVariables(parsedConfig.disableCssVariablesPonyfill)
       .finally(() => {
         this._onReady();
-        const impressionEvent = createImpressionEvent({
-          verticalKey: parsedConfig.search?.verticalKey,
-          standAlone: true
-        });
-        this._analyticsReporterService.report(impressionEvent, { includeQueryId: false });
+        if (this._analyticsReporterService) {
+          const impressionEvent = createImpressionEvent({
+            verticalKey: parsedConfig.search?.verticalKey,
+            standAlone: true
+          });
+          this._analyticsReporterService.report(impressionEvent, { includeQueryId: false });
+        }
       });
   }
 

src/answers-umd.js

@@ -305,18 +305,19 @@ class Answers {
     return asyncDeps.finally(() => {
       this._onReady();
 
-      const isSearchBarActive = this.components.getActiveComponent(SearchComponent.type);
-      const numActiveComponents = this.components.getNumActiveComponents();
-
-      if (isSearchBarActive) {
+      const searchBarIsActive = !!this.components.getActiveComponent(SearchComponent.type);
+      if (searchBarIsActive && this._analyticsReporterService) {
+        const numActiveComponents = this.components.getNumActiveComponents();
         const impressionEvent = createImpressionEvent({
           verticalKey: parsedConfig.search?.verticalKey,
           // check that 1 or 2 components are active because the
           // search bar also creates the autocomplete component
           standAlone: numActiveComponents >= 1 && numActiveComponents <= 2
         });
         this._analyticsReporterService.report(impressionEvent, { includeQueryId: false });
-      } else {
+      }
+
+      if (!searchBarIsActive) {
         this._initQueryUpdateListener(parsedConfig.search);
       }
 

tests/acceptance/fixtures/html/universalinitialsearch.html

@@ -19,7 +19,6 @@
     ANSWERS.init({
       apiKey: 'df4b24f4075800e5e9705090c54c6c13',
       experienceKey: 'sdkacceptancetests',
-      businessId: '3350634',
       experienceVersion: 'PRODUCTION',
       templateBundle: TemplateBundle.default,
       search: {