Merge 28324a9 into 530f4bd

yext · Dec 12, 2022 · c188f2b · c188f2b
2 parents 530f4bd + 28324a9
commit c188f2b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@yext/answers-search-ui",
-  "version": "1.15.1",
+  "version": "1.15.2",
   "description": "Javascript Search Programming Interface",
   "main": "dist/answers-umd.js",
   "repository": {

diff --git a/src/core/analytics/analyticsreporter.js b/src/core/analytics/analyticsreporter.js
@@ -108,8 +108,7 @@ export default class AnalyticsReporter {
       ytag('optin', true);
       cookieData = ytag('yfpc', null);
     } else if (this._conversionTrackingEnabled) {
-      console.error('Tried to enable conversion tracking without including ytag');
-      return false;
+      console.error('Conversion Tracking is enabled without supplying ytag. Analytics event sent without Conversion Tracking info.');
     }
 
     if (!(event instanceof AnalyticsEvent)) {

diff --git a/tests/core/analytics/analyticsreporter.js b/tests/core/analytics/analyticsreporter.js
@@ -73,8 +73,8 @@ describe('reporting events', () => {
   it('logs a console error if opted in and ytag missing', () => {
     analyticsReporter.setConversionTrackingEnabled(true);
     const consoleErrorSpy = jest.spyOn(console, 'error');
-    expect(analyticsReporter.report(new AnalyticsEvent('thumbs_up'))).toBeFalsy();
-    expect(consoleErrorSpy).toHaveBeenLastCalledWith('Tried to enable conversion tracking without including ytag');
+    expect(analyticsReporter.report(new AnalyticsEvent('thumbs_up'))).toBeTruthy();
+    expect(consoleErrorSpy).toHaveBeenLastCalledWith('Conversion Tracking is enabled without supplying ytag. Analytics event sent without Conversion Tracking info.');
   });
 
   it('includes cookies if opted in and ytag present', () => {