Merge branch 'develop' into hotfix/v1.8.4

.eslintrc.json

@@ -0,0 +1,18 @@
+{
+   "extends": ["semistandard"],
+   "ignorePatterns": ["dist", "docs"],
+   "globals": {
+      "beforeEach": true,
+      "beforeAll": true,
+      "describe": true,
+      "it": true,
+      "expect": true,
+      "jest": true,
+      "DOMParser": true,
+      "ytag": true,
+      "test": true,
+      "fixture": true,
+      "CustomEvent": true,
+      "ANSWERS": true
+    }
+}

.github/workflows/coverage.yml

@@ -0,0 +1,31 @@
+# This workflow will run our tests, generate an lcov code coverage file,
+# and send that coverage to Coveralls 
+
+name: Code Coverage
+
+on:
+  push:
+    branches-ignore: dev/*
+  pull_request:
+
+jobs:
+  Coveralls:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [14.x]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm ci
+    - run: npx gulp templates
+    - run: npx jest --coverage
+    - name: Coveralls
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/npm_publish.yml

@@ -0,0 +1,31 @@
+name: NPM publish on new release
+
+on: 
+  release:
+    types: [created]
+    branches: 
+      - master
+
+jobs:
+  npm-publish:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [15.x]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node-version }}
+        registry-url: https://registry.npmjs.org/
+    - run: npm ci
+    - run: npm run build
+    - run: npm run prepublishOnly
+    - run: npm publish
+    - run: npm run postpublish
+      env:
+        NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

README.md

@@ -1,5 +1,11 @@
 # Answers Search UI
-Outline:
+
+<h3>
+  <a href='https://coveralls.io/github/yext/answers-search-ui?branch=master'>
+    <img src='https://coveralls.io/repos/github/yext/answers-search-ui/badge.svg?branch=master' alt='Coverage Status' />
+  </a>
+</h3>
+
 1. [Install / Setup](#install-and-setup)
 2. [ANSWERS.init Configuration Options](#answersinit-configuration-options)
    - [Vertical Pages Configuration](#vertical-pages-configuration)

conf/gulp-tasks/library.gulpfile.js

@@ -2,6 +2,7 @@ const { series, parallel, src, dest, watch } = require('gulp');
 const path = require('path');
 const postcss = require('gulp-postcss');
 const sass = require('gulp-sass');
+sass.compiler = require('sass');
 
 const getLibraryVersion = require('./utils/libversion');
 const { BundleType, BundleTaskFactory } = require('./bundle/bundletaskfactory');

conf/gulp-tasks/template/bundletemplatestaskfactory.js

@@ -111,7 +111,7 @@ class BundleTemplatesTaskFactory {
           plugins: [
             '@babel/syntax-dynamic-import',
             ['@babel/plugin-transform-runtime', {
-              'corejs': 3
+              corejs: 3
             }],
             '@babel/plugin-transform-arrow-functions',
             '@babel/plugin-proposal-object-rest-spread',

conf/gulp-tasks/template/createcleanfiles.js

@@ -27,7 +27,7 @@ function createCleanFilesTask (locale) {
  */
 function _cleanFiles (callback, locale) {
   const precompiledFile = getPrecompiledFileName(locale);
-  del.sync([ `./dist/${precompiledFile}` ]);
+  del.sync([`./dist/${precompiledFile}`]);
   callback();
 }
 

conf/gulp-tasks/template/createprecompiletemplates.js

@@ -54,7 +54,7 @@ function precompileTemplates (callback, outputFile, processAST) {
         processPartialName: function (fileName, a, b, c) {
           // Strip the extension and the underscore
           // Escape the output with JSON.stringify
-          let name = fileName.split('.')[0];
+          const name = fileName.split('.')[0];
           if (name.charAt(0) === '_') {
             return JSON.stringify(name.substr(1));
           } else {
@@ -64,8 +64,8 @@ function precompileTemplates (callback, outputFile, processAST) {
         // TBH, this isn't really needed anymore since we don't name files like so 'foo.bar.js', but this is here to
         // support that use case.
         customContext: function (fileName) {
-          let name = fileName.split('.')[0];
-          let keys = name.split('.');
+          const name = fileName.split('.')[0];
+          const keys = name.split('.');
           let context = 'context';
           for (let i = 0; i < keys.length; i++) {
             context = context += '["' + keys[i] + '"]';
@@ -78,7 +78,7 @@ function precompileTemplates (callback, outputFile, processAST) {
       root: 'context',
       noRedeclare: true,
       processName: function (filePath) {
-        let path = filePath.replace('src/ui/templates', '');
+        const path = filePath.replace('src/ui/templates', '');
         return declare.processNameByPath(path, '').replace('.', '/');
       }
     }))

conf/i18n/constants.js

@@ -3,7 +3,7 @@ exports.TRANSLATION_FLAGGER_REGEX = /TranslationFlagger.flag\((\s)*\{[^;]+?\}(\s
 exports.DEFAULT_LOCALE = 'en';
 
 const LANGUAGES_TO_LOCALES = {
-  'en': [
+  en: [
     'en_AE',
     'en_AI',
     'en_AS',
@@ -65,7 +65,7 @@ const LANGUAGES_TO_LOCALES = {
     'en_US',
     'en_ZA'
   ],
-  'es': [
+  es: [
     'es_BO',
     'es_CO',
     'es_CU',
@@ -77,7 +77,7 @@ const LANGUAGES_TO_LOCALES = {
     'es_NI',
     'es_US'
   ],
-  'fr': [
+  fr: [
     'fr_BE',
     'fr_BL',
     'fr_CA',
@@ -89,18 +89,18 @@ const LANGUAGES_TO_LOCALES = {
     'fr_MC',
     'fr_RE'
   ],
-  'it': [
+  it: [
     'it_CH',
     'it_IT'
   ],
-  'de': [
+  de: [
     'de_AT',
     'de_CH',
     'de_DE',
     'de_EU',
     'de_LU'
   ],
-  'ja': [
+  ja: [
     'ja_JP'
   ]
 };

conf/i18n/runtimecallgeneratorutils.js

@@ -52,6 +52,6 @@ function formatPluralForms (translatorResult) {
  * @returns {string}
  */
 function escapeSingleQuotes (str) {
-  const regex = new RegExp('\'', 'g');
+  const regex = /'/g;
   return str.replace(regex, '\\\'');
 }

conf/i18n/translatehelpervisitor.js

@@ -107,7 +107,7 @@ class TranslateHelperVisitor {
       ...statement,
       path: {
         ...statement.path,
-        parts: [ this._processTranslationHelper ],
+        parts: [this._processTranslationHelper],
         original: this._processTranslationHelper
       }
     };

conf/i18n/translator.js

@@ -164,7 +164,7 @@ class Translator {
     const placeholders = {};
     let placeholderMatch;
 
-    const placeholderRegex = new RegExp(/\[\[([a-zA-Z0-9]+)\]\]/, 'g');
+    const placeholderRegex = /\[\[([a-zA-Z0-9]+)\]\]/g;
     while ((placeholderMatch = placeholderRegex.exec(phrase)) != null) {
       if (placeholderMatch.length >= 2) {
         placeholders[placeholderMatch[1]] = placeholderMatch[0];