Skip to content

Commit

Permalink
Version 1.16.7 (#1864)
Browse files Browse the repository at this point in the history
### Fixes
- Revert change to icons (#1857) made in v1.16.6
  • Loading branch information
nmanu1 committed Feb 13, 2024
2 parents a672339 + f0f2061 commit ec2fab4
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 27 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@yext/answers-search-ui",
"version": "1.16.6",
"version": "1.16.7",
"description": "Javascript Search Programming Interface",
"main": "dist/answers-umd.js",
"repository": {
Expand Down
5 changes: 0 additions & 5 deletions src/ui/sass/modules/_SearchBar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -280,18 +280,13 @@ $searchbar-button-text-color-active: var(--yxt-searchbar-button-text-color-base)

&-buttonImage .Icon svg, .Icon-image
{
display: block;
width: 2em;
height: 2em;
}

&-instructions {
display: none;
}

&-CustomLoadingImage {
display: block;
}
}

// If custom icons are supplied, the SVGs simply alternate opacity
Expand Down
4 changes: 2 additions & 2 deletions src/ui/templates/icons/builtInIcon.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<span class="Icon Icon--{{iconName}} {{classNames}}" aria-hidden="true">
<div class="Icon Icon--{{iconName}} {{classNames}}" aria-hidden="true">
{{icon iconName complexContentsParams}}
</span>
</div>
4 changes: 2 additions & 2 deletions src/ui/templates/icons/icon.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<span class="Icon Icon--{{name}} {{classNames}}" aria-hidden="true">
<div class="Icon Icon--{{name}} {{classNames}}" aria-hidden="true">
{{#if iconUrl}}
<img src="{{iconUrl}}" alt="" class="Icon-image">
{{else}}
{{icon iconName complexContentsParams}}
{{/if}}
</span>
</div>
4 changes: 2 additions & 2 deletions src/ui/templates/icons/iconPartial.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<span class="Icon Icon--{{#if iconName}}{{iconName}}{{else}}custom{{/if}} {{classNames}}" aria-hidden="true">
<div class="Icon Icon--{{#if iconName}}{{iconName}}{{else}}custom{{/if}} {{classNames}}" aria-hidden="true">
{{#if iconUrl}}
<img src="{{iconUrl}}" alt="" class="Icon-image">
{{else}}
{{icon iconName complexContentsParams}}
{{/if}}
</span>
</div>
24 changes: 12 additions & 12 deletions src/ui/templates/icons/searchBarIcon.hbs
Original file line number Diff line number Diff line change
@@ -1,41 +1,41 @@
{{#if showLoadingIndicator}}
{{#if customLoadingIconUrl}}
<span class="yxt-SearchBar-CustomLoadingImage js-yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon yxt-SearchBar-Icon--inactive">
<div class="yxt-SearchBar-CustomLoadingImage js-yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon yxt-SearchBar-Icon--inactive">
{{> icons/iconPartial iconUrl=customLoadingIconUrl}}
</span>
</div>
{{else}}
<span class="yxt-SearchBar-AnimatedIcon js-yxt-SearchBar-LoadingIndicator yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon
<div class="yxt-SearchBar-AnimatedIcon js-yxt-SearchBar-LoadingIndicator yxt-SearchBar-LoadingIndicator js-yxt-SearchBar-Icon
yxt-SearchBar-Icon--inactive Icon--lg">
<svg class= "yxt-SearchBar-LoadingIndicator-AnimatedIcon" viewBox="0 0 72 72">
<circle class="yxt-SearchBar-LoadingIndicator-Circle" cx="36" cy="36" r="33" stroke="black" stroke-width="3" fill="none"/>
</svg>
</span>
</div>
{{/if}}
{{/if}}

{{#if submitIcon}}
<span class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
<div class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
{{> icons/builtInIcon iconName=submitIcon}}
</span>
</div>
{{else if _config.customIconUrl}}
<span class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
<div class="yxt-SearchBar-buttonImage js-yxt-SearchBar-buttonImage js-yxt-SearchBar-Icon">
{{> icons/iconPartial iconUrl=_config.customIconUrl}}
</span>
</div>
{{else}}
<span class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedForward js-yxt-SearchBar-Icon
<div class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedForward js-yxt-SearchBar-Icon
{{#unless autoFocus}} yxt-SearchBar-Icon--inactive{{/unless}}">
{{> icons/builtInIcon
iconName='yext_animated_forward'
classNames='yxt-SearchBar-MagnifyingGlass--static Icon--lg'
complexContentsParams=forwardIconOpts.complexContentsParams
}}
</span>
<span class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedReverse js-yxt-SearchBar-Icon
</div>
<div class="yxt-SearchBar-AnimatedIcon js-yxt-AnimatedReverse js-yxt-SearchBar-Icon
{{#if autoFocus}} yxt-SearchBar-Icon--inactive{{/if}}">
{{> icons/builtInIcon
iconName='yext_animated_reverse'
classNames='yxt-SearchBar-Yext--static Icon--lg'
complexContentsParams=forwardIconOpts.complexContentsParams
}}
</span>
</div>
{{/if}}
2 changes: 1 addition & 1 deletion src/ui/templates/icons/voiceSearchIcon.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
{{/if}}
</div>
<span class="yxt-SearchBar-voiceSearchText sr-only"></span>
</div>
</div>

0 comments on commit ec2fab4

Please sign in to comment.