Skip to content

Commit

Permalink
change sessionStorage console.error to warning instead (#1509)
Browse files Browse the repository at this point in the history
If sessionStorage doesn't exist or usage is blocked by the browser
we still default to using the old session-id cookie, but an error
would still be printed even though nothing is "going wrong".

Rose said we can change to a warning. I also added a little extra context.

J=SLAP-1518
TEST=manual
  • Loading branch information
oshi97 committed Aug 16, 2021
1 parent f50e084 commit fe2e360
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -764,8 +764,8 @@ export default class Core {
window.sessionStorage.setItem('sessionId', sessionId);
}
return sessionId;
} catch (e) {
console.error(e);
} catch (err) {
console.warn('Unable to use browser sessionStorage for sessionId.\n', err);
}
}
return null;
Expand Down

0 comments on commit fe2e360

Please sign in to comment.