Fix search bar buttons on very small screens #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
reviewed
Jan 15, 2021
Good call. I just tested it and it didn't work with ie11 so I'm going to look into an alternative solution. The UI refresh without this change does work on IE11 |
Update: Discussed offline. The change does in fact work in IE11. The issue I was seeing was a separate CORS issue that occurred because how how I was serving the SDK locally. (SLAP-1024) |
tmeyer2115
reviewed
Jan 15, 2021
| @@ -121,6 +121,7 @@ $searchbar-button-text-color-active: var(--yxt-searchbar-button-text-color-base) | |||
| &-clear | |||
| { | |||
| display: flex; | |||
| flex-shrink: 0; | |||
There was a problem hiding this comment.
Since we removed the flex-grow from &-input is this still necessary?
There was a problem hiding this comment.
I tested this PR without flex-shrink it and the buttons still shrink at low resolutions. The buttons and the search bar elements are all flex items because their parent (the search bar form) has display: flex; set. By default the flex items have a flex-shrink of 1, which makes them susceptible to shrinking. Setting flex-shrink to 0 prevents that.
tmeyer2115
approved these changes
Jan 15, 2021
cea2aj
added a commit
that referenced
this pull request
Mar 5, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
cea2aj
added a commit
that referenced
this pull request
Mar 5, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
cea2aj
added a commit
that referenced
this pull request
Mar 5, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
cea2aj
added a commit
that referenced
this pull request
Mar 5, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
tmeyer2115
pushed a commit
that referenced
this pull request
Mar 16, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
tmeyer2115
pushed a commit
that referenced
this pull request
Mar 31, 2021
Fix the search bar styling so that the buttons don't disappear on small screens On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens. J=SLAP-999 TEST=visual Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safare and on a windows laptop on IE11.
Merged
tmeyer2115
added a commit
that referenced
this pull request
Mar 31, 2021
### Bug Fixes - Fixed a styling bug that caused the search bar buttons to disappear on small screens. (#1243) - When a spell check query suggestion is clicked, the proper `queryTrigger` is now sent. (#1230) - Fixed some small typos about the `SearchBar` configuration in the README. (#1229) - Fixed a small race condition that occurred when the `ANSWERS` instance was loaded on the page before the `templateBundle`. (#1305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the search bar styling so that the buttons don't disappear on small screens
On screens with very small widths (<350px width), the search bar clear and search buttons shrink and eventually disappear as the screen width decreases. This PR prevents the buttons from shrinking and disappearing on very small screens.
J=SLAP-999
TEST=visual
Build a site and view it at various sizes between 300px and 400px wide and confirm that the search bar buttons no longer shrink or disappear. Test on a browswerstack iphone 8 with safari and on a windows laptop on IE11.