Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition node-sass to dart-sass #1417

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented May 25, 2021

Update package.json to use sass package and remove deprecated node-sass
Set gulp-sass compiler to use dart-sass

J=SLAP-1310
TEST=compile

Update package.json to use sass package and remove node-sass
Set gulp-sass compiler to use dart-sass

J=SLAP-1310
TEST=auto
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 56.775% when pulling ef8f7a2 on dev/node-sass-deprecation-update into bc94606 on develop.

Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yen-tt yen-tt merged commit fc4dcba into develop May 25, 2021
@yen-tt yen-tt deleted the dev/node-sass-deprecation-update branch May 25, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants