Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change semistandard to eslint #1428

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Change semistandard to eslint #1428

merged 4 commits into from
Jun 8, 2021

Conversation

cjiang2000
Copy link
Contributor

@cjiang2000 cjiang2000 commented Jun 7, 2021

Use ESLint with the same configuration as Semistandard version 16.0.0
Updated codebase to match new version

Fixed the following rules(automatic):

  • Using const when possible
  • Strings using single quotes
  • Spacing tweaks
  • Using dot accessors instead of bracket accessors
  • Not using quotes for object properties when possible

Fixed the following rules(manual):

  • Using Regex literals instead of RegExp
  • Added default values for latter parameters
  • Not using hasOwnProperty()
  • Using forEach instead of map
  • Added brackets around case declarations
  • Using const when possible

J = SLAP-1343
TEST = Manual

Built a page in Japanese and opened it.

@coveralls
Copy link

coveralls commented Jun 7, 2021

Coverage Status

Coverage decreased (-0.003%) to 56.79% when pulling 1e4f4fa on dev/semistandard into deaa78d on develop.

@cea2aj
Copy link
Member

cea2aj commented Jun 7, 2021

@oshi97 I know we have brought up just using eslint for all our repos. Does switching to that make more sense here? Otherwise I'm happy with this change

@oshi97
Copy link
Contributor

oshi97 commented Jun 8, 2021

@oshi97 I know we have brought up just using eslint for all our repos. Does switching to that make more sense here? Otherwise I'm happy with this change

yeah I think that makes sense, semistandard is just eslint without configurability so it shouldn't be hard to eject out of it

@cjiang2000 cjiang2000 changed the title Change semistandard version from 13.0.1 to 16.0.0 Change semistandard to eslint Jun 8, 2021
Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjiang2000 cjiang2000 merged commit f2c7eb9 into develop Jun 8, 2021
@cjiang2000 cjiang2000 deleted the dev/semistandard branch June 14, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants