Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.4 #1432

Merged
merged 6 commits into from
Jun 10, 2021
Merged

v1.8.4 #1432

merged 6 commits into from
Jun 10, 2021

Commits on Jun 8, 2021

  1. bump version to 1.8.4

    oshi97 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4ba5441 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. fix facets not being persisted when applied from the URL (#1429)

    When sending facets in a search request, there is logic that first checks
    whether FACET_FILTER_NODES exist. If none exist, we default to using whatever
    was persisted in the URL. The issue was that this logic was not being duplicated
    for persisting facets in the URL. If facets were applied from the URL on a search
    run on page load, for example, we would try to persist facets using the FACET_FILTER_NODE
    state on page load, which would be no filter nodes existing. Defaulting this to whatever
    is persisted in the URL fixes the issue.
    
    J=SLAP-1377
    TEST=manual,auto
    
    saw that I can double refresh the page with facets applied from the url, and also
    that the back and forwards buttons work for facets
    
    added a additional refresh and forward nav actions to the facetsonload acceptance test to
    test double refreshing and forward naving with facets from the URL
    added a new facetsonload.html for this test, with the only difference being
     searchOnChange: true for facets (which is the default as well as more common config setting)
    oshi97 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    868b706 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    713bd6a View commit details
    Browse the repository at this point in the history
  3. Fix notices.

    tmeyer2115 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a366b7f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Configuration menu
    Copy the full SHA
    c51dd2a View commit details
    Browse the repository at this point in the history
  2. Fix stylelint errors.

    tmeyer2115 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    a78d4a1 View commit details
    Browse the repository at this point in the history