Fix inverted check mark in filter #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=SLAP-1519 TEST=manual see that check mark is not inverted in filter box from en and ar locale
oshi97
reviewed
Aug 16, 2021
| @@ -170,7 +170,8 @@ | |||
| left: -20px; | |||
| width: 3px; | |||
| height: 9px; | |||
| transform: rotate(45deg) translateY(-50%); | |||
| transform: rotate(45deg) translateY(-50%) #{"/*rtl:rotate(45deg) translateX(-100%)*/"}; | |||
| /*!rtl:ignore*/ | |||
There was a problem hiding this comment.
is this ignoring the border-right?
There was a problem hiding this comment.
For my own edification, why do we need to ignore the border for RTL?
There was a problem hiding this comment.
rtl plugin would change this right border styling to left border styling. But we want the right border to show instead of the left one so it's not inverted when we rotate/translate the symbol
There was a problem hiding this comment.
ohh I see ignoring is different than removing, I thought this would just remove the line for rtl
oshi97
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=SLAP-1519
TEST=manual
see that check mark is not inverted in filter box from en and ar locale