update edge supported locales for voice search #1519
Conversation
Ran my codepen that brute force checks locales on edge, which works by by turning on speech recognition for 10s, and adding the locale to a list if a 'network' occurs. After 10s, the speech recognition is aborted and a 'no-speech' error is expected. Also added a zh-cn and zh-tw to the supported locales list, even though they're not currently locales the SDK has built in, in case a user manually supplies these locales. J=SLAP-1532 TEST=manual,auto manually test a number of the locales (~a third of them)
| 'pt-br', | ||
| 'pt-pt', | ||
| 'sv-se', | ||
| 'zh-hans-cn', |
There was a problem hiding this comment.
just confirming 'zh-hans-sg` and 'zh-hant-mo' aren't supported?
There was a problem hiding this comment.
they are not, you can very quickly test them here https://codepen.io/oshi97/pen/RwVKKzB
There was a problem hiding this comment.
or by hacking the searchbar's SpeechRecognition instance through dev tools with ANSWERS.components._activeComponents.find( // find the searchbar and go through its instance variables
| if (modifier) { | ||
| return formatLocaleForEdge(language, modifier); | ||
| } |
There was a problem hiding this comment.
If a locale isn't in the compatibility list but it has a modifier, we return it? I would expect that if the locale isn't in the compatibility list, we return just the language, not a language and modifier.
There was a problem hiding this comment.
If zh-hans-bob isn't supported, we can return zh-hans instead of just zh
by default edge will interpret zh on its own as zh-hans, so this only matters for zh-hant-[unsupported-region]
Ran my codepen that brute force checks locales on edge, which works by by turning on speech recognition for 10s, and adding the locale to a list if a 'network' occurs. After 10s, the speech recognition is aborted and a 'no-speech' error is expected. Also added a zh-cn and zh-tw to the supported locales list, even though they're not currently locales the SDK has built in, in case a user manually supplies these locales. J=SLAP-1532 TEST=manual,auto manually test a number of the locales (~a third of them)
Ran my codepen that brute force checks locales on edge, which works by
by turning on speech recognition for 10s, and adding the locale
to a list if a 'network' occurs. After 10s, the speech recognition
is aborted and a 'no-speech' error is expected.
Also added a zh-cn and zh-tw to the supported locales list, even
though they're not currently locales the SDK has built in, in case
a user manually supplies these locales.
J=SLAP-1532
TEST=manual,auto
manually test a number of the locales (~a third of them)