Fix useragent acceptance test #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
approved these changes
Nov 29, 2021
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fix the failing useragent acceptance tests The useragent acceptance tests have been failing due to the error: `undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")')`, and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again. This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page. J=none TEST=none Confirm that the tests now pass.
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fix the failing useragent acceptance tests The useragent acceptance tests have been failing due to the error: `undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")')`, and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again. This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page. J=none TEST=none Confirm that the tests now pass.
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fix the failing useragent acceptance tests The useragent acceptance tests have been failing due to the error: `undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")')`, and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again. This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page. J=none TEST=none Confirm that the tests now pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the failing useragent acceptance tests
The useragent acceptance tests have been failing due to the error:
undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")'), and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again.This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page.
J=none
TEST=none
Confirm that the tests now pass.