Should Deploy Major Version Fix #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
approved these changes
Apr 6, 2022
cea2aj
added a commit
that referenced
this pull request
Apr 6, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 7, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
cea2aj
added a commit
that referenced
this pull request
Apr 8, 2022
Fixes the should_deploy_major_version.yml Github Action
One issue was that the `git tag --list` command was returning a list of tags separated by new lines which were each passed as a separate argument in the `if [ -z` line. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the `-z` command.
Secondly, the `git tag --list` wasn't taking into account the search-bar prefix. By adding `${{ inputs.ignore_prefix }}` to the `git tag --list` param, we can properly check the tags for the search bar.
J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for `search-bar-` which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed for `search-bar-v1.2.7` or `search-bar-v1.1.7` (assuming the v1.3.0 tag exists)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the should_deploy_major_version.yml Github Action
One issue was that the
git tag --listcommand was returning a list of tags separated by new lines which were each passed as a separate argument in theif [ -zline. We can fix this by surrounding TAGS_FOR_NEXT_MINOR with double quotes so that only one string and therefore one argument is passed to the-zcommand.Secondly, the
git tag --listwasn't taking into account the search-bar prefix. By adding${{ inputs.ignore_prefix }}to thegit tag --listparam, we can properly check the tags for the search bar.J=SLAP-2023
TEST=manual
Run the bash script locally, however substitute ${{ inputs.ignore_prefix }} for
search-bar-which is what Github Actions does before running the script. Confirm that the script indicates that a GITHUB_REF_NAME of 'search-bar-v1.3.1' should deploy a major, but a major version should not be deployed forsearch-bar-v1.2.7orsearch-bar-v1.1.7(assuming the v1.3.0 tag exists)