wcag: use appropriate aria roles for search input #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcginnis
changed the title
tmeyer2115
reviewed
Apr 20, 2023
benmcginnis
force-pushed
the
hotfix/v1.15.5
branch
3 times, most recently
from
be697fd
to
d40cbc1
Compare
EmilyZhang777
previously approved these changes
Apr 24, 2023
A customer noticed that we had an aria-expanded attribute on the search input, which they flagged as incorrect. Based on https://w3c.github.io/aria/#combobox, it appears we need to use the combobox role on the input element and search on the form element. Additionally ran manual accessibility checks with Chrome Lighthouse and Firefox to inspect the accessibility tree. This revealed the need to properly label the autocomplete results listbox control. J=TECHOPS-8758 TEST=auto, manual Reran acceptance tests
benmcginnis
force-pushed
the
hotfix/v1.15.5
branch
from
d40cbc1
to
6a23563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer noticed that we had an aria-expanded attribute on the search input, which they flagged as incorrect. Based on https://w3c.github.io/aria/#combobox, it appears we need to use the combobox role on the input element and search on the form element.
J=TECHOPS-8758
TEST=auto
Reran acceptance tests