Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject cloud region into build #1818

Merged
merged 2 commits into from
May 4, 2023
Merged

Inject cloud region into build #1818

merged 2 commits into from
May 4, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented May 3, 2023

Add support for a CLOUD_REGION env variable
which allows either US or EU to be set as the
cloud region. Defaults to US.

J=BACK-2269
TEST=manual

Manually ran a build with the CLOUD_REGION
env variable set to US and EU and confirmed
the CLOUD_REGION variable was set correctly
in dist/answers.js

Add support for a CLOUD_REGION env variable
which allows either US or EU to be set as the
cloud region. Defaults to US.

J=B-2269
TEST=manual

Manually ran a build with the CLOUD_REGION
env variable set to US and EU and confirmed
the CLOUD_REGION variable was set correctly
in dist/answers.js
@coveralls
Copy link

coveralls commented May 3, 2023

Coverage Status

Coverage: 61.4% (-0.04%) from 61.441% when pulling 5a02fd5 on dev/eu1-endpoints into 96cc51e on develop.

@cea2aj cea2aj changed the title Inject cloud region into build output Inject cloud region into build May 3, 2023
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cea2aj cea2aj merged commit 4240dd3 into develop May 4, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants