Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix breaking unit test and upgdated package version #1839

Merged
merged 7 commits into from
Oct 4, 2023
Merged

fix breaking unit test and upgdated package version #1839

merged 7 commits into from
Oct 4, 2023

Conversation

jesuyedavid
Copy link
Contributor

No description provided.

cea2aj
cea2aj reviewed Oct 4, 2023
View reviewed changes
package.json Show resolved Hide resolved
@cea2aj
Copy link
Member

cea2aj commented Oct 4, 2023

It looks like there is a similar testing error in the code coverage checks which I think are worth fixing

cea2aj
cea2aj approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@jesuyedavid jesuyedavid merged commit cc55531 into master Oct 4, 2023
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cea2aj cea2aj cea2aj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesuyedavid @cea2aj