Bump Core to v2.4.0 #1843
Merged
Bump Core to v2.4.0 #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nmanu1
added a commit
that referenced
this pull request
Dec 1, 2023
### Fixes - Updated `@yext/search-core` to v2.4.0 to properly support new Rich Text & Markdown field types returned as raw html in direct answers (#1843)
Merged
nmanu1
added a commit
that referenced
this pull request
Dec 1, 2023
This PR bumps the `search-core` version to v2.4.0 to get support for new Rich Text & Markdown field types returned as raw html in direct answers (see [release notes](https://github.com/yext/search-core/releases/tag/v2.4.0)). We had already added [support](yext/answers-hitchhiker-theme#1138) to render these fields in the Theme, but without the Core update, a search that returns an `html` field type gives an error and doesn't actually get rendered. J=TECHOPS-10638 TEST=manual Point the site from the techops to a locally served version of the SDK with this version bump and see that an HTML field type for a featured snippet direct answer is properly rendered instead of throwing an error. <img width="1728" alt="Screenshot 2023-11-30 at 4 55 46 PM" src="https://github.com/yext/answers-search-ui/assets/88398086/82233e9d-9d1e-4e26-960a-8b579a0eac4c"> Note: this PR is the same as #1843, but with a corrected version bump (v1.16.4 instead of v1.16.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
search-coreversion to v2.4.0 to get support for new Rich Text & Markdown field types returned asraw html in direct answers (see release notes). We had already added support to render these fields in the Theme, but without the Core update, a search that returns an
htmlfield type gives an error and doesn't actually get rendered.J=TECHOPS-10638
TEST=manual
Point the site from the techops to a locally served version of the SDK with this version bump and see that an HTML field type for a featured snippet direct answer is properly rendered instead of throwing an error.