Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump browserify-sign to v4.2.3 #1869

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

EmilyZhang777
Copy link
Collaborator

Bump browserify-sign to v4.2.3 to resolve a vulnerability.

J=VULN-38744
TEST=auto,manual

Ran npm run test and npm run acceptance. Ran npx serve -p 9999 and clicked around.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Coverage Status

coverage: 62.02%. remained the same
when pulling b9ea30a on dev/vulnerabilities-2
into 66fef30 on master.

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you also check that running the build and using the generated bundles in the Theme test site was fine? it looks like browserify-sign is dep of a library we use for bundling, so it would affect our build step

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should point to a hotfix branch if we're making a new version, or develop if we're not

@EmilyZhang777 EmilyZhang777 changed the base branch from master to hotfix/v1.17.1 March 7, 2024 19:19
@EmilyZhang777
Copy link
Collaborator Author

did you also check that running the build and using the generated bundles in the Theme test site was fine? it looks like browserify-sign is dep of a library we use for bundling, so it would affect our build step

yep! Tested HH theme still works with a local build.

@EmilyZhang777 EmilyZhang777 merged commit bd429a2 into hotfix/v1.17.1 Mar 7, 2024
12 of 15 checks passed
@EmilyZhang777 EmilyZhang777 deleted the dev/vulnerabilities-2 branch March 7, 2024 20:20
@EmilyZhang777 EmilyZhang777 mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants