Fix Filter Options Highlighting #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanu1
reviewed
Mar 8, 2024
Added more details and a screenshot. |
nmanu1
approved these changes
Mar 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when we moved from
innerHTMLtotextContent, it broke the filter options highlighting since the<strong>tag is no longer applied properly. This PR fixes the issue while still avoid insecure document method.J=TECHOPS-11319
TEST=auto, manual
Ran
npm run test. Serve answers-search-ui locally and checked out hh theme. Made sure the highlighting are working.https://drive.google.com/file/d/1lBVOA759BPwsqmENIv6kFe2FasR25EKO/view?usp=sharing