Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/vertical-cards: rename results -> verticalresults #483

Merged
merged 4 commits into from
Feb 3, 2020

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Feb 3, 2020

TEST=manual
Test that vertical results and universal results still load

TEST=manual
Test that vertical results and universal results still load
Copy link
Collaborator

@tmeyer2115 tmeyer2115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the README so that any references to ResultsComponent are also renamed.

src/ui/sass/modules/_VerticalResults.scss Outdated Show resolved Hide resolved
@oshi97 oshi97 merged commit 8722fcc into feature/vertical-cards Feb 3, 2020
@oshi97 oshi97 deleted the vertical-cards/rename-vresults branch February 3, 2020 20:58
oshi97 added a commit that referenced this pull request Feb 10, 2020
* feature/vertical-cards: rename results -> verticalresults

TEST=manual
Test that vertical results and universal results still load

* missed some renames

* update readme

* change css classes back
oshi97 added a commit that referenced this pull request Mar 5, 2020
* feature/vertical-cards: rename results -> verticalresults

TEST=manual
Test that vertical results and universal results still load

* missed some renames

* update readme

* change css classes back
oshi97 added a commit that referenced this pull request Mar 20, 2020
* feature/vertical-cards: rename results -> verticalresults

TEST=manual
Test that vertical results and universal results still load

* missed some renames

* update readme

* change css classes back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants