-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical Results: Pull vertical config from component config if exists #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73791c7
to
b0d6430
Compare
oshi97
approved these changes
Mar 14, 2020
alexisgrow
added a commit
that referenced
this pull request
Mar 14, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
alexisgrow
added a commit
that referenced
this pull request
Mar 16, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 16, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 17, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 19, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 19, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 20, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Mar 31, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Apr 2, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
oshi97
pushed a commit
that referenced
this pull request
Apr 6, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
alexisgrow
added a commit
that referenced
this pull request
Apr 7, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
alexisgrow
added a commit
that referenced
this pull request
Apr 22, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
tmeyer2115
pushed a commit
that referenced
this pull request
Apr 24, 2020
#535) If verticalPages config is present in the component config, prefer it over the one in the top-level config. TEST=manual Run answers experience locally putting config in top level config, component config, then both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.