Cards: Allow custom card type for custom card components #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user enters a cardType that is built in, no changes. If they enter a cardYype that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe chaanges in browser.
alexisgrow
force-pushed
the
allow-all-card-types
branch
from
1333123
to
d8ebbad
Compare
|
I'm so sorry |
|
🤣 |
alexisgrow
added a commit
that referenced
this pull request
Mar 14, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
alexisgrow
added a commit
that referenced
this pull request
Mar 16, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 16, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 17, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 18, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 19, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 19, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 20, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Mar 31, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Apr 2, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
oshi97
pushed a commit
that referenced
this pull request
Apr 6, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
alexisgrow
added a commit
that referenced
this pull request
Apr 7, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
alexisgrow
added a commit
that referenced
this pull request
Apr 22, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
tmeyer2115
pushed a commit
that referenced
this pull request
Apr 24, 2020
If a user enters a cardType that is built in, no changes. If they enter a cardType that is not built in, the library interprets it as a component name. TEST=manual Update the config to use built in vs custom cardTypes. Observe changes in browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user enters a cardType that is built in, no changes. If
they enter a cardYype that is not built in, the library interprets
it as a component name.
TEST=manual
Update the config to use built in vs custom cardTypes. Observe
chaanges in browser.