Navigation Component: Empty or undefined verticalKey has same behavio… #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r as null If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
reviewed
Mar 21, 2020
| @@ -99,7 +99,7 @@ export class Tab { | |||
|
|
|||
| // For tabs without config ids, map their URL to the configID | |||
| // to avoid duplication of renders | |||
| if (tab.verticalKey === null && tabs[tab.verticalKey] === undefined) { | |||
| if (!tab.verticalKey && !tabs[tab.verticalKey]) { | |||
There was a problem hiding this comment.
I know it was like this in the old code, but do we need the && !tabs[tab.verticalKey] ?
There was a problem hiding this comment.
Oh good point, is this the logic we should have:
if (!tab.verticalKey && !tabs[tab.url])?
oshi97
pushed a commit
that referenced
this pull request
Mar 31, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 1, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 2, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 6, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 6, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
oshi97
pushed a commit
that referenced
this pull request
Apr 6, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
alexisgrow
added a commit
that referenced
this pull request
Apr 7, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
alexisgrow
added a commit
that referenced
this pull request
Apr 22, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
tmeyer2115
pushed a commit
that referenced
this pull request
Apr 24, 2020
#578) If an implementer passed in a verticalKey that was empty or undefined, its entry would be ignored in the navigation component. Changing the null check so any falsy verticalKey is treated the same. TEST=manual Test on local answers instance that universal verticalPages config is used when omitting vertical key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r as null
If an implementer passed in a verticalKey that was empty or undefined, its
entry would be ignored in the navigation component. Changing the null check
so any falsy verticalKey is treated the same.
TEST=manual
Test on local answers instance that universal verticalPages config is
used when omitting vertical key.