Add border around the SearchBar component when viewing on Mobile. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that the SearchBar component has a border when viewed on Mobile. The border is the same as the one that already exists on the Desktop view. Without a border, the SearchBar's input was impossible to find against a white background on Mobile. J=SPR-2001 TEST=manual Verified that the border appears the same accross Desktop and Mobile in both IE11 and Chrome.
tmeyer2115
requested review from
benmcginnis,
oshi97,
alexisgrow and
nbramblett
tmeyer2115
added a commit
that referenced
this pull request
Apr 24, 2020
This PR ensures that the SearchBar component has a border when viewed on Mobile. The border is the same as the one that already exists on the Desktop view. Without a border, the SearchBar's input was impossible to find against a white background on Mobile. J=SPR-2001 TEST=manual Verified that the border appears the same accross Desktop and Mobile in both IE11 and Chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the SearchBar component has a border when viewed on
Mobile. The border is the same as the one that already exists on the Desktop
view. Without a border, the SearchBar's input was impossible to find against
a white background on Mobile. This resolves issue #624 .
J=SPR-2001
TEST=manual
Verified that the border appears the same across Desktop and Mobile in both
IE11 and Chrome.