-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VerticalResults: Hide applied filters when displaying no results #690
Conversation
Shouldn't this kind of behavior be configurable in the noResults object? |
hmm idk asking pms |
Rose said to just do this for now, in the future we can use allResultsForVertical.appliedQueryFilters |
When displayAllResults is true, before a page would display applied filters in the results header, like it does for normal results. It's still the case that only nlp filters are displayed. J=SPR-2003 TEST=manual Checked that page was displaying applied filters for no results Made change checked that filters no longer display for no results checked that filters still display for regular results
f838ebf
to
76c15df
Compare
changed base to 13.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, probably want someone else to approve too though
@oshi97 are the NLP filters displayed in this no results case? If so, I don't think that's something we want shown either. |
Sorry I reread my commit message and it was really unclear, this commit stops NLP filters from being displayed as well. |
When displayAllResults is true, before a page would display applied filters in the results header, like it does for normal results. It's still the case that only nlp filters are displayed. J=SPR-2003 TEST=manual Checked that page was displaying applied filters for no results Made change checked that filters no longer display for no results checked that filters still display for regular results
When displayAllResults is true, before a page would display
applied filters in the results header, like it does for normal
results.
This PR sets showAppliedFilters to false when displaying no results, which will hide any applied filters in the header (so nlp filters, static/facet filters, and sort options)
J=SPR-2003
TEST=manual
Checked that page was displaying applied filters for no results
Made change
checked that filters no longer display for no results
checked that filters still display for regular results