update readme: fallback cta icon is star #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from this thread! https://yext.slack.com/archives/GREFVUD7V/p1587420183160800 |
alexisgrow
reviewed
Apr 21, 2020
| @@ -652,7 +652,8 @@ Note: A CTA without both a label and icon will not be rendered. | |||
| const callsToAction = [{ | |||
| // Label below the CTA icon, default null | |||
| label: 'cta label', | |||
| // Icon name for the CTA that is one of the SDK icons, default to undefined (no icon) | |||
| // Icon name for the CTA that is one of the SDK icons, defaults to undefined (no icon). If your icon | |||
| // is not recognized it will default to 'star'. | |||
There was a problem hiding this comment.
Is this what happens? That seems fancy/magical and we don't do that anywhere else for icons, right?
There was a problem hiding this comment.
Oh no we do this everywhere for icons!
There was a problem hiding this comment.
woah, TIL! Awesome, LGTM!
There was a problem hiding this comment.
It's in lines 146-149 of handlebarsrenderer.js
alexisgrow
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.