update universal results borders #708
Conversation
margin on top and bottom of yxt-Results-filters was not receiving border-left and border-right (because margin does not receive border in css) causing gaps to appear TEST=manual check that vertical results on vertical search, vertical results on universal searchh, accordion results do not have gaps in the border, and otherwise appearance is unchanged
|
I'm slightly worried about this breaking somebody's page layout, but the only other alternative I could see was removing all of the border-left and border-right for everything in vertical results when it is in a universal result and adding a border around the container. This might be safer though? |
| background-color: $results-filters-background; | ||
| border-top: $results-border; |
There was a problem hiding this comment.
Does this need to be removed from titleBar and added here? If possible, it would be better to leave below the title I think
There was a problem hiding this comment.
Added a second commit showing the other possible solution for the double borders (which gives yxt-Results-filters border-bottom instead of giving it a border-top).
Prior to this commit yxt-Results-filters never has a border-top or border-bottom, so if yxt-Results-filters is missing borders are going to double up. I can't think of something better than just giving it either border-bottom or border-top and moving other borders around?
There was a problem hiding this comment.
I think I like the first commit more, if only because it keeps the
& .yxt-Accordion-list
{
border-top: $border-legacy;
}
they asked me to add ._. and it's slightly shorter
oshi97
force-pushed
the
universal-results-borders
branch
from
682aa8f
to
aab065c
Compare
oshi97
force-pushed
the
universal-results-borders
branch
from
9c6f309
to
7077a0a
Compare
…ust to minimize changes
* update universal results borders margin on top and bottom of yxt-Results-filters was not receiving border-left and border-right (because margin does not receive border in css) causing gaps to appear Also fix double border TEST=manual check that vertical results on vertical search, vertical results on universal searchh, accordion results do not have gaps in the border, and otherwise appearance is unchanged
margin on top and bottom of yxt-Results-filters
was not receiving border-left and border-right
(because margin does not receive border in css)
causing gaps to appear
TEST=manual
check that vertical results on vertical search,
vertical results on universal searchh, accordion results
do not have gaps in the border, and otherwise appearance is unchanged