Add global noResults configuration option. #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new option can be set in the top-level Answers.init configuration. It can be used by both VerticalResults and the MapComponent. Both of these components have logic that will favor an individual noResults config to the one in globalStorage. Additionally, both components will apply the same sane defaults to any noResults attributes not specified. A change was also made to ensure that the VerticalResults component passes along its noResults config to any child MapComponent, to ensure consistency. Note that Rose requested the displayAllResults default be false for the MapComponent TEST=manual Ensured correct behavior in all the following situations: VerticalResults with included MapComponent - Specified noResults config for VerticalResults. - Specified noResults config at global level. - Specified noResults config at both levels. - Specified noResults config at neither level. VerticalResults and separate MapComponent - Specified noResults config for both components. - Specified noResults config at global level. - Specified noResults config at global and component levels. - Specified noResults config at neither levels.
alexisgrow
reviewed
Apr 21, 2020
tmeyer2115
added a commit
that referenced
this pull request
Apr 24, 2020
This new option can be set in the top-level Answers.init configuration. It can be used by both VerticalResults and the MapComponent. Both of these components have logic that will favor an individual noResults config to the one in globalStorage. Additionally, both components will apply the same sane defaults to any noResults attributes not specified. A change was also made to ensure that the VerticalResults component passes along its noResults config to any child MapComponent, to ensure consistency. Note that Rose requested the displayAllResults default be false for the MapComponent TEST=manual Ensured correct behavior in all the following situations: VerticalResults with included MapComponent - Specified noResults config for VerticalResults. - Specified noResults config at global level. - Specified noResults config at both levels. - Specified noResults config at neither level. VerticalResults and separate MapComponent - Specified noResults config for both components. - Specified noResults config at global level. - Specified noResults config at global and component levels. - Specified noResults config at neither levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new option can be set in the top-level Answers.init configuration. It can
be used by both VerticalResults and the MapComponent. Both of these components
have logic that will favor an individual noResults config to the one in
globalStorage. Additionally, both components will apply the same sane defaults
to any noResults attributes not specified. A change was also made to ensure
that the VerticalResults component passes along its noResults config to any
child MapComponent, to ensure consistency.
Note that Rose requested the displayAllResults default be false for the
MapComponent
TEST=manual
Ensured correct behavior in all the following situations:
VerticalResults with included MapComponent
VerticalResults and separate MapComponent