Let url be null on Legacy card. #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let url be null-ed by the user, so that it can be forced to default to a linkless title.
oshi97
reviewed
Apr 23, 2020
tmeyer2115
reviewed
Apr 24, 2020
tmeyer2115
approved these changes
Apr 24, 2020
tmeyer2115
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Let url be null on Legacy card. Let url be null-ed by the user, so that it can be forced to default to a linkless title. * Add parens and update standard card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let url be null-ed by the user, so that it can be forced to default to
a non-linking title.
TEST=manual
Verified that setting the config url to null would make the title not display a link for legacy cards.