VerticalPages config: Add iconUrl option #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbramblett
reviewed
Apr 23, 2020
oshi97
reviewed
Apr 23, 2020
tmeyer2115
reviewed
Apr 24, 2020
alexisgrow
commented
Apr 24, 2020
There was a problem hiding this comment.
This wasn't part of spec originally. This request was from Liz/Bryan to get into v1.0.0 for the SPR-2065 item. I think the main issue is that this inconsistency makes it weird for the HH theme, because the icon (in verticalsToConfig) is used for both UniversalResults (which supports iconUrl) and No Results (which doesn't).
tmeyer2115
approved these changes
Apr 24, 2020
tmeyer2115
pushed a commit
that referenced
this pull request
Apr 24, 2020
Allow an implementer to specify an iconURL in the verticalPages config. This allows them to use an icon that is not in the built-in set that ships with the template bundle. If both iconUrl and icon are passed in, they will both be passed through to the IconComponent which has logic to determine which takes priority. TEST=manual In dev site for a Vertical page, use in an iconUrl in the verticalPages config. View in browser to confirm custom icon displays. Also test to verify that built-in icons still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an implementer to specify an iconURL in the verticalPages config. This allows them to use an icon that is not in the built-in set that ships with the template bundle. If both iconUrl and icon are passed in, they will both be passed through to the IconComponent which has logic to determine which takes priority.
TEST=manual
In dev site for a Vertical page, use in an iconUrl in the verticalPages config. View in browser to confirm custom icon displays. Also test to verify that built-in icons still work.