Make updates to @babel plugins suggested by Dependabot. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot suggested we update the versions of the following @babel plugins: - @babel/plugin-proposal-object-rest-spread - @babel/plugin-transform-arrow-functions - @babel/plugin-transform-runtime Even though these plugins are devDependencies, they should be kept up-to-date. We use these plugins to transform our source code when creating the various asset bundles. It's possible, then, that security issues in these plugins could make their way into the builds of the SDK. These were only minor version upgrades, so the risk should be low. TEST=manual These @babel plugins are mainly used to help polyfill the SDK's source code and make it IE11 friendly. To test, then, I ran a few smoke tests on a demo site in IE11. I made sure search, navigation, spell check, autocomplete, and qa submission functionality worked and no errors were present in the console. I also made sure to exercise some areas of the code where we use arrow functions or the spread operator, to ensure the polyfilling of those continued to work.
oshi97
approved these changes
Apr 24, 2020
|
lgtm! |
tmeyer2115
added a commit
that referenced
this pull request
Apr 24, 2020
Dependabot suggested we update the versions of the following @babel plugins: - @babel/plugin-proposal-object-rest-spread - @babel/plugin-transform-arrow-functions - @babel/plugin-transform-runtime Even though these plugins are devDependencies, they should be kept up-to-date. We use these plugins to transform our source code when creating the various asset bundles. It's possible, then, that security issues in these plugins could make their way into the builds of the SDK. These were only minor version upgrades, so the risk should be low. TEST=manual These @babel plugins are mainly used to help polyfill the SDK's source code and make it IE11 friendly. To test, then, I ran a few smoke tests on a demo site in IE11. I made sure search, navigation, spell check, autocomplete, and qa submission functionality worked and no errors were present in the console. I also made sure to exercise some areas of the code where we use arrow functions or the spread operator, to ensure the polyfilling of those continued to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot suggested we update the versions of the following @babel plugins:
Even though these plugins are devDependencies, they should be kept up-to-date.
We use these plugins to transform our source code when creating the various
asset bundles. It's possible, then, that security issues in these plugins could
make their way into the builds of the SDK. These were only minor version
upgrades, so the risk should be low.
TEST=manual
These @babel plugins are mainly used to help polyfill the SDK's source code and
make it IE11 friendly. To test, then, I ran a few smoke tests on a demo site in
IE11. I made sure search, navigation, spell check, autocomplete, and qa
submission functionality worked and no errors were present in the console. I
also made sure to exercise some areas of the code where we use arrow functions
or the spread operator, to ensure the polyfilling of those continued to work.