Formless search #750
Merged
Formless search #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows the SearchBar to be configured to not use a form as the query submission context. By default, a form is used, unless a client sets the new 'useForm' config option to false. This was done to support clients that wanted to use a SearchBar on an ASP.NET page. J=SPR-2175 TEST=manual Tested the following scenarios for SearchBars set to useForm true and false: - Entering text and hitting enter. - Entering text and hitting the submit button. - Entering text and clearing. - Clicking autocomplete option. - Using keys to navigate to and select an autocomplete option. - Clear button appears in the correct situations. - Search animation works as expected. - Near me query works as expected. In the above scenarios, made sure Analytics worked correctly, if applicable.
alexisgrow
reviewed
May 4, 2020
alexisgrow
approved these changes
May 4, 2020
Yep, I imagine we will. SearchBar is the most common problem child for now, but will probably be good to offer formless options for all. |
tmeyer2115
added a commit
that referenced
this pull request
May 5, 2020
This PR allows the SearchBar to be configured to not use a form as the query submission context. By default, a form is used, unless a client sets the new 'useForm' config option to false. This was done to support clients that wanted to use a SearchBar on an ASP.NET page. J=SPR-2175 TEST=manual Tested the following scenarios for SearchBars set to useForm true and false: - Entering text and hitting enter. - Entering text and hitting the submit button. - Entering text and clearing. - Clicking autocomplete option. - Using keys to navigate to and select an autocomplete option. - Clear button appears in the correct situations. - Search animation works as expected. - Near me query works as expected. In the above scenarios, made sure Analytics worked correctly, if applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow SearchBar to be created without form as submission context.
This PR allows the SearchBar to be configured to not use a form as the query
submission context. By default, a form is used, unless a client sets the new
'useForm' config option to false. This was done to support clients that wanted
to use a SearchBar on an ASP.NET page.
J=SPR-2175
TEST=manual
Tested the following scenarios for SearchBars set to useForm true and false:
In the above scenarios, made sure Analytics worked correctly, if applicable.