README: Add modifier option to the VerticalResults portion of the doc… #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisgrow
commented
May 5, 2020
nbramblett
reviewed
May 5, 2020
nbramblett
reviewed
May 5, 2020
README.md
Outdated
| @@ -494,6 +494,8 @@ ANSWERS.addComponent('VerticalResults', { | |||
| maxNumberOfColumns: 1, | |||
| // Optional, whether to display the total number of results, default true | |||
| showResultCount: true, | |||
| // Optional, a modifier that will be appended to a class on the results list like this `yxt-Results--{modifier}` | |||
| modifier: 'Standard', | |||
There was a problem hiding this comment.
Similar question about defaulting to Standard. Is this a purely additive classname change?
There was a problem hiding this comment.
This isn't a default, this is an example, I will update it to empty.
alexisgrow
force-pushed
the
modifier-readme
branch
from
a85fef6
to
8a6b7a2
Compare
tmeyer2115
pushed a commit
that referenced
this pull request
May 5, 2020
#753) Add modifier option to the VerticalResults portion of the documentation. TEST=none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modifier option to the VerticalResults portion of the documentation.
TEST=none