Pin gettext-extractor to avoid a breaking change #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-gerner
approved these changes
May 24, 2024
vijay267
approved these changes
May 24, 2024
Merged
nmanu1
added a commit
that referenced
this pull request
May 24, 2024
### Fixes - Fixed an error where upgrading to the latest version of Jambo was incompatible with Node 12 (#335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins
gettext-extractorto a minor version (v3.6) prior to v3.7.1 that was released with a change that breaks Jambo upgrades performed with Node 12 and npm 6. That change added support for TS v5 and removed support for older TS versions. When upgrading Jambo via the code editor, the version ofgettext-extractorwas being updated to the latest version, which would in turn upgrade to the latest version of TS (v5.4.5) in the acceptable range (4-5). But, v5.4.5 of TS requires Node 14 or higher, causing an error when usingengine-strict=truein the.npmrc. Also, because the code editor by default uses Node 12 and npm 6, we can't useoverridesin the package.json (which was released in npm 8) to pin the transitive TS dep to v4.J=WAT-4073
TEST=manual
Tried locally pointing the Theme to my local Jambo repo and saw that install was successful with
engine-strict=true, when it gives the same error reported in the Slack thread when trying to force install an older version of Jambo.