Provide Endpoints for EU Cloud Region #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates an EndpointProvider class to offer a way to get endpoints for EU. J=BACK-2270 TEST=auto,manual Ran tests under tests/. Manually started a test site and made sure the api request use the correct endpoints. Change-Id: I5c5bbd99e9c3f0f67d0b6817e0a0db6eeaf2f231
Pull Request Test Coverage Report for Build 4886892156
💛 - Coveralls |
benmcginnis
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
Change-Id: I27d289eecf66523ddde6cfcceaf905ae966f27cb
cea2aj
reviewed
May 3, 2023
cea2aj
reviewed
May 3, 2023
|
This is looking really good! |
Change-Id: I1b13509a1ffb48c8a7def438260825407d3f0779
|
Since this repo uses git flow, this change should be based on develop, and the PR should target develop. When we are ready to release the next version, we bump the version number in develop in another PR and then merge develop into master |
cea2aj
approved these changes
May 3, 2023
benmcginnis
reviewed
May 4, 2023
Change-Id: I40c3c538871a5a14e9ff8fd7c79617d99369781c
benmcginnis
reviewed
May 4, 2023
benmcginnis
approved these changes
May 4, 2023
Change-Id: I4c3ead6096d90a49fa7f2479de40de194912733e
|
LGTM! I think we're good to squash & merge |
cea2aj
requested changes
May 4, 2023
Change-Id: I9ba835765871534befce6091d40ac36eb611a0f3
Change-Id: I4e06b9d501586735c3e67b6d5ee753132a5ed71a
Merged
cea2aj
added a commit
that referenced
this pull request
May 8, 2023
### Features Support the EU Cloud region (#233) - We introduced two new configuration options: cloudRegion and environment. The search endpoints are hosted in both the US and in Europe, and the cloudRegion config option determines which endpoints are used. The environment config option supports both Production and Sandbox. The SandboxEndpoints object is now deprecated, and the environment config option should be used instead to specify the sandbox environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an EndpointProvider class to offer a way to get endpoints for EU.
J=BACK-2270
TEST=auto,manual
Ran tests under tests/.
Manually started a test site and made sure the api request use the correct endpoints.
Change-Id: I5c5bbd99e9c3f0f67d0b6817e0a0db6eeaf2f231