Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Document to DocumentResult #251

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Rename Document to DocumentResult #251

merged 3 commits into from
Sep 29, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Sep 29, 2023

The type "Document" was conflicting with the same type in node and in the browser which was causing some TS issues. Renaming this fixes this conflict.

J=BACK-2523
TEST=compile

@cea2aj cea2aj requested a review from a team as a code owner September 29, 2023 18:17
@coveralls
Copy link

coveralls commented Sep 29, 2023

Pull Request Test Coverage Report for Build 6355779700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.352%

Totals Coverage Status
Change from base Build 6355138504: 0.0%
Covered Lines: 219
Relevant Lines: 239

💛 - Coveralls

@cea2aj cea2aj merged commit cdff1b2 into develop Sep 29, 2023
14 checks passed
@nmanu1 nmanu1 mentioned this pull request Dec 7, 2023
nmanu1 added a commit that referenced this pull request Dec 7, 2023
### Changes
- Added support for document verticals (#249, #251, #252)
nmanu1 added a commit that referenced this pull request Dec 7, 2023
- Added support for document verticals (#249, #251, #252)
nmanu1 added a commit that referenced this pull request Dec 7, 2023
Changes
- Added support for document verticals (#249, #251, #252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants