Remove node 14 tests and add 18

yext · Dec 8, 2023 · b96a629 · b96a629
1 parent ba52aaa
commit b96a629
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -5,6 +5,8 @@ on: [push, pull_request]
 jobs:
   call_run_tests:
     uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
+    with:
+      node_matrix: '["16.x", "18.x"]'
 
   # It's necessary to use v12 of the react-testing-library since v13 was updated to only support react 18
   call_run_tests-react-17:
@@ -13,12 +15,12 @@ jobs:
       build_script: |
         npm i -D react@17 react-dom@17 @types/react@17 @testing-library/react@12
         npm run build
-      node_matrix: '["16.x"]'
+      node_matrix: '["16.x", "18.x"]'
 
   call_run_tests-react-16:
     uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
     with:
       build_script: |
         npm i -D react@16.14 react-dom@16.14 @types/react@16.14 @testing-library/react@12
         npm run build
-      node_matrix: '["16.x"]'
+      node_matrix: '["16.x", "18.x"]'