Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description and keywords to package.json #138

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

juliannzhou
Copy link
Contributor

This PR adds description and keywords to package.json. The description is copied from README and keywords provided by product.

J=SLAP-2190
TEST=manual

@juliannzhou juliannzhou requested a review from a team as a code owner June 29, 2022 20:31
@coveralls
Copy link

coveralls commented Jun 29, 2022

Coverage Status

Coverage remained the same at 78.889% when pulling 6d474ac on dev/descriptions_and_keywords into 3be88de on develop.

package.json Outdated Show resolved Hide resolved
package.json Outdated
"answers",
"yext",
"react",
"components"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did product want "components" as a keyword here even though this library doesn't provide any components?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library technically has a component (AnswersHeadlessProvider) though it's really not about components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product only gave me one list, so I updated the repos with the same list. Should I ask product to give a list for every public repository?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would ask for a list for each repo since they have different purposes

@oshi97
Copy link
Contributor

oshi97 commented Jun 29, 2022

let's merge into develop for this one too

@juliannzhou juliannzhou changed the base branch from main to develop June 29, 2022 23:16
@juliannzhou juliannzhou requested review from oshi97 and nmanu1 July 7, 2022 15:25
package.json Outdated
"yext",
"react",
"components"
"Search",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change hooks, react, and react binding to lowercase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw most of the keywords on npm are all lowercase, and since they are case-insensitive, I just ask Julianne to update everything to lowercase to be consistent!

@juliannzhou juliannzhou requested review from oshi97 and yen-tt July 7, 2022 20:32
@juliannzhou juliannzhou merged commit 0a34725 into develop Jul 7, 2022
@juliannzhou juliannzhou deleted the dev/descriptions_and_keywords branch July 7, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants