-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description and keywords to package.json #138
Conversation
package.json
Outdated
"answers", | ||
"yext", | ||
"react", | ||
"components" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did product want "components" as a keyword here even though this library doesn't provide any components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library technically has a component (AnswersHeadlessProvider) though it's really not about components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product only gave me one list, so I updated the repos with the same list. Should I ask product to give a list for every public repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would ask for a list for each repo since they have different purposes
let's merge into develop for this one too |
package.json
Outdated
"yext", | ||
"react", | ||
"components" | ||
"Search", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change hooks, react, and react binding to lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw most of the keywords on npm are all lowercase, and since they are case-insensitive, I just ask Julianne to update everything to lowercase to be consistent!
This PR adds description and keywords to package.json. The description is copied from README and keywords provided by product.
J=SLAP-2190
TEST=manual