Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.4.0 #148

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Version 1.4.0 #148

merged 4 commits into from
Jul 27, 2022

Conversation

tmeyer2115
Copy link
Contributor

@tmeyer2115 tmeyer2115 commented Jul 27, 2022 •
edited by alextaing
Loading

Version 1.4.0

Changes

  • Upgraded to the latest version of search-headless (v1.4.0) to introduce new features in search-core.

nmanu1 and others added 3 commits July 19, 2022 14:46
@nmanu1
Merge main (v1.3.0) into develop (#146)
2321459 
Merge main (v1.3.0) into develop
@nmanu1
Update version to 1.4.0-alpha.147 (#147)
0547034 
Bump the Headless version to 1.4.0-beta.120 to incorporate the changes in Core to make `Result` a generic.

J=SLAP-2232
TEST=none
@alextaing
bump version and headless version
d1feaf5
@tmeyer2115 tmeyer2115 requested a review from a team as a code owner July 27, 2022 16:17
@coveralls
Copy link

coveralls commented Jul 27, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 79.612% when pulling 2518f24 on release/1.4 into 85df100 on main.

@alextaing alextaing changed the title v1.4 Version 1.4.0 Jul 27, 2022
@yen-tt
Copy link
Contributor

yen-tt commented Jul 27, 2022

do we want to specify the interface changes in in the release notes related to search-headless version bump since we do reexport them in this package? Otherwise, I guess the reader can navigate to the release notes of search-headless for the changelog

@alextaing
Copy link
Contributor

alextaing commented Jul 27, 2022 •
edited
Loading

do we want to specify the interface changes in in the release notes related to search-headless version bump since we do reexport them in this package? Otherwise, I guess the reader can navigate to the release notes of search-headless for the changelog

I linked search core since that is where the changes originated and since those release notes have the most detail. Is that OK? If so, should I also link to search-core in the release notes of search-headless as well? @tmeyer2115 @yen-tt

Also, the reason for the actions failure is because I forgot to add a "v" in the branch name. Is it something worth going back and changing?

@tmeyer2115 tmeyer2115 merged commit 233b24f into main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yen-tt yen-tt yen-tt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tmeyer2115 @coveralls @yen-tt @alextaing @nmanu1