Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search-headless to v2 alpha #151

Merged
merged 3 commits into from
Aug 16, 2022
Merged

update search-headless to v2 alpha #151

merged 3 commits into from
Aug 16, 2022

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Aug 16, 2022

Had to update the msw mocks to intercept the new search endpoints.

J=None
TEST=manual

unit tests pass again with no errors
before this there would be an "Invalid API Key" error

Had to update the msw mocks to intercept the new search endpoints.

J=None
TEST=manual

unit tests pass again with no errors
before this there would be an "Invalid API Key" error
@oshi97 oshi97 requested a review from a team as a code owner August 16, 2022 17:49
@coveralls
Copy link

coveralls commented Aug 16, 2022

Coverage Status

Coverage remained the same at 79.612% when pulling 9b01770 on dev/search-headless-2.0 into 56e1a2f on develop.

@@ -32,7 +32,7 @@
"generate-notices": "generate-license-file --input package.json --output THIRD-PARTY-NOTICES --overwrite"
},
"dependencies": {
"@yext/search-headless": "^1.4.0",
"@yext/search-headless": "^2.0.0-alpha.130",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the headless-react version too so we can publish a new alpha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

@oshi97 oshi97 merged commit f61022c into develop Aug 16, 2022
@oshi97 oshi97 deleted the dev/search-headless-2.0 branch August 16, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants