Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address vulnerabilities in @xmldom/xmldom #165

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Address vulnerabilities in @xmldom/xmldom #165

merged 1 commit into from
Nov 8, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Nov 7, 2022

Update the version of @xmldom/xmldom to address Snyk vulnerabilities in the package.

J=none
TEST=none

@nmanu1 nmanu1 requested a review from a team as a code owner November 7, 2022 21:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.231% when pulling 36df978 on dev/snyk into 97b7dc1 on develop.

tatimblin
tatimblin reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@tatimblin tatimblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't package.json updated in this one?

@nmanu1
Copy link
Contributor Author

nmanu1 commented Nov 7, 2022 •
edited
Loading

why isn't package.json updated in this one?

@xmldom/xmldom isn't a direct dependency, so it's not specified in our package.json. the dependency through which it's introduced pins to a major version, so updating the package-lock (via npm update) is sufficient here

tatimblin
tatimblin approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@tatimblin tatimblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanu1 nmanu1 merged commit 7ba9508 into develop Nov 8, 2022
@nmanu1 nmanu1 deleted the dev/snyk branch November 8, 2022 13:43
nmanu1 added a commit that referenced this pull request Nov 8, 2022
@nmanu1
Address vulnerabilities in @xmldom/xmldom (#165)
ab3c673 
Update the version of `@xmldom/xmldom` to address Snyk vulnerabilities in the package.

J=none
TEST=none
@nmanu1 nmanu1 mentioned this pull request Nov 8, 2022
Merged
nmanu1 added a commit that referenced this pull request Nov 8, 2022
@nmanu1
v2.0.1 (#167)
fb10f62 
### Bug Fixes
- Address security vulnerabilities in `@xmldom/xmldom` (#165)
@tmeyer2115 tmeyer2115 mentioned this pull request Nov 15, 2022
Merged
tmeyer2115 added a commit that referenced this pull request Nov 15, 2022
@tmeyer2115
Version 2.1.0
04477aa 
## Version 2.1.0
### Changes
- Base TS Config file was renamed. (#164)

### Fixes
- Dependency vulnerabilities were remediated. (#163, #165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatimblin tatimblin tatimblin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmanu1 @coveralls @tatimblin