Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v2.4.0 #196

Merged
merged 4 commits into from Dec 8, 2023
Merged

Prepare v2.4.0 #196

merged 4 commits into from Dec 8, 2023

Conversation

nmanu1
Copy link
Collaborator

@nmanu1 nmanu1 commented Dec 8, 2023

Bump package.json to v2.4.0 and search-headless to v2.5.0.

J=none
TEST=auto

Update tests to run on Node 16 and 18 and drop 14 since tsup doesn't seem to support 14.

@coveralls
Copy link

coveralls commented Dec 8, 2023

Coverage Status

coverage: 94.34%. remained the same
when pulling b0e3e62 on dev/bump-headless-2.5.0
into cb6228b on develop.

@nmanu1 nmanu1 marked this pull request as ready for review December 8, 2023 16:32
@nmanu1 nmanu1 requested a review from a team as a code owner December 8, 2023 16:32
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! do you think it will be simple enough to bump the other libraries to support node 18 (and add 20 while we're at it)?

@nmanu1
Copy link
Collaborator Author

nmanu1 commented Dec 8, 2023

nice! do you think it will be simple enough to bump the other libraries to support node 18 (and add 20 while we're at it)?

I'm not anticipating too much difficulty based on the quick check I did. I added it for our unit testing node matrix here and tests pass. But, I think it would be good to make an item to more thoroughly investigate whether we fully support 20 (and to add 18 to the unit testing) in all the libraries in case there are edge cases

@nmanu1 nmanu1 merged commit 8530bf1 into develop Dec 8, 2023
23 checks passed
@nmanu1 nmanu1 deleted the dev/bump-headless-2.5.0 branch December 8, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants