Add useAnswersUtilities #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
reviewed
Oct 25, 2021
src/useAnswersUtilities.ts
Outdated
| export type AnswersUtilities = AnswersHeadless['utilities']; | ||
|
|
||
| export function useAnswersUtilities(): AnswersUtilities { | ||
| return useContext(AnswersActionsContext).utilities; |
There was a problem hiding this comment.
Maybe we need to rename AnswersActionsContext now that it supplies both actions and utilities.
There was a problem hiding this comment.
Sure, I'm thinking AnswersContext or AnswersHeadlessContext
tmeyer2115
approved these changes
Oct 25, 2021
tmeyer2115
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a useAnswersUtilites hook which provides the utility methods from AnswersHeadless
Because
AnswersActionsContextno longer supplies just actions, it is renamed toAnswersHeadlessContext.AnswersActionsContextis also renamed toAnswersHeadlessProviderJ=SLAP-1649
TEST=manual
Update the Facets component to use the utility hook and manually test in the sample app