Refactor StaticFilters #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update StaticFilters to be a functional component - update StaticFilters to use new interface from answers-headless changes in this PR instead of managing its own filter state. - update filter utils to reflect the new interfaces from answers-headless Note: the package/answers-headless version will be updated once that pr is merged and publish. J=SLAP-1661 TEST=manual - hook to local answers-headless changes, and start sample-app. See that filters work accordingly.
…ons from headless
…react into dev/filter-update
…react into dev/filter-update
oshi97
reviewed
Nov 8, 2021
| @@ -75,7 +75,12 @@ function RemovableFilter({ filter }: {filter: DisplayableFilter }): JSX.Element | |||
| } | |||
|
|
|||
| const onRemoveStaticFilterOption = () => { | |||
| document.getElementById(`${filter.filter.fieldId + "_" + filter.filter.value}`)?.click(); | |||
| if (!filter.filterCollectionId) { | |||
There was a problem hiding this comment.
do we need this console.error if answers-headless also logs an error for this? maybe filterCollectionId should be a required field of DisplayableFilter
There was a problem hiding this comment.
filterCollectionId can't be required for DisplayableFilter since DisplayableFilter can also be use for type Facet or NLP filters, which doesn't have filterCollectionId. A check is needed here because Typescript would yell that filter.filterCollectionId can be undefined, which is not allow for function setFilterOption. I think it's ok to keep
oshi97
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor StaticFilters and update AppliedFilters to follow the new public interface from answers-headless.
setFilterOptionfunction instead of performing a click eventJ=SLAP-1661
TEST=manual