Add labels to applied static filters #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
reviewed
Nov 4, 2021
|
|
||
| export interface DecoratedAppliedFiltersConfig { | ||
| showFieldNames?: boolean, | ||
| hiddenFields?: Array<string>, | ||
| labelText?: string, | ||
| delimiter?: string, | ||
| staticFiltersGroupLabels?: Record<string, StaticFiltersLabelConfig>, |
There was a problem hiding this comment.
Would it be simpler if this was just a mapping of fieldId to label? instead of a mapping of fieldId to an object with a single label property
There was a problem hiding this comment.
Yes, that would be simpler. I did it this way to make it more clear what the mapping was between, but I could also just do that with documentation instead
There was a problem hiding this comment.
Ah ok, let's just go with the string to string mapping for now, that way people don't have to understand what a StaticFiltersLabelConfig is. if needed we can tweak it later
oshi97
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify group labels for applied static filters.
DecoratedAppliedFiltersaccepts a mapping offieldIdto group label. If no label is provided, it defaults back to using thefieldIdas the group label.J=SLAP-1658
TEST=manual
Check that specifying a group label for a static filter fieldId is reflected when a filter with that fieldId is applied