Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export * answers-headless #52

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented Nov 9, 2021

This commit adds an export * from answers-headless statement.
This way, the sample-app doesn't have to use a transient answers-core
or answers-headless dependency for models.
This also makes local development slightly nicer, since transitive dependencies aren't visible
when doing a local npm install.

J=SLAP-1684
TEST=manual

see the sample app runs

This commit adds an export * from answers-headless statement.
This way, the sample-app doesn't have to use a transient answers-core
or answers-headless dependency for models.

J=SLAP-1684
TEST=manual

see the sample app runs
@coveralls
Copy link

coveralls commented Nov 9, 2021

Coverage Status

Coverage increased (+0.3%) to 75.532% when pulling caa4ca4 on dev/dont-leak-transitive-headless-dep into 9ec7dbb on main.

@oshi97 oshi97 merged commit b159efd into main Nov 10, 2021
@oshi97 oshi97 deleted the dev/dont-leak-transitive-headless-dep branch November 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants