Update React Sample App according to new Headless State #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update StaticFilter to no longer use ID with headless public interface update function to transform static filters to displayableFilter to no longer account for ID Note: will update package path/version when new headless version is publish J=SLAP-1688 TEST=manual hook sample-app with local headless branch. Setup two static filters, and see that they work accordingly
…dless-react into dev/remove-id-in-filter
yen-tt
changed the title
cea2aj
reviewed
Nov 16, 2021
cea2aj
reviewed
Nov 16, 2021
cea2aj
reviewed
Nov 16, 2021
added 2 commits
November 16, 2021 12:38
…dless-react into dev/remove-id-in-filter
oshi97
reviewed
Nov 16, 2021
…l address in another item
oshi97
reviewed
Nov 16, 2021
oshi97
reviewed
Nov 16, 2021
| export function useAutocomplete(isVertical: boolean): [AutocompleteResult[], () => Promise<void>] { | ||
| const answersActions = useAnswersActions(); | ||
| const autocompleteNetworkIds = useRef({ latestRequest: 0, responseInState: 0 }); | ||
| const [ autocompleteResults, setAutoCompleteResults ] = useState<AutocompleteResult[]>([]); |
There was a problem hiding this comment.
we have an item to be consistent about the capitzliation for AutoComplete vs Autocomplete but I think within this method it would be nice to be consistent as well
There was a problem hiding this comment.
oh yea, good catch. I made some changes to headless to have it lowercase, missed it here
oshi97
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update React sample app and tests based on the updated headless state
SearchStatusStateandQueryStateSearchBarto manage its own autocomplete results in component state. Added a useAutocomplete hookinputDropdownin another itemAppliedFilterandStaticFilterto no longer use ID with headless public interfaceresetFacetsonhandleFilterOptionChangeJ=SLAP-1693
TEST=manual
jest tests passed
smoke tested sample-app with new headless version