Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectAnswer Component #59

Merged
merged 3 commits into from
Nov 24, 2021
Merged

DirectAnswer Component #59

merged 3 commits into from
Nov 24, 2021

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Nov 24, 2021

  • Added DirectAnswer component to display featured snippet and field value direct answer in universal and vertical search page.

J=SLAP-1725
TEST=manual

search for 'bryan phone number' and 'where/who is joe exotic' and see that both snippet and filterValue direct answer appears in universal and vertical page.

- Added DirectAnswer component to display featured snippet and field value direct answer in universal and vertical search page.

J=SLAP-1725
TEST=manual

search for 'bryan phone number' and 'where/who is joe exotic' and see that both snippet and filterValue direct answer appears in universal and vertical page.
@coveralls
Copy link

coveralls commented Nov 24, 2021

Coverage Status

Coverage remained the same at 75.532% when pulling 2719f39 on dev/direct-answers into fefc014 on main.

@yen-tt yen-tt requested a review from cea2aj November 24, 2021 19:10
Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@yen-tt yen-tt merged commit 187cf6b into main Nov 24, 2021
@yen-tt yen-tt deleted the dev/direct-answers branch November 24, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants