Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-filterSearch redirect to result page #73

Closed
wants to merge 3 commits into from

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Dec 2, 2021

Changes:

  • Added two pages: a page with Name, Location, and Language FilterSearch component, with a submit button. When submit, it will redirect to a new result page, containing the same three FilterSearch with the selected options and the corresponding vertical results.
  • Added a custom FilterSearch component to accommodate for the button in location filterSearch to get user location and update the input in filtersearch
    • NOTE: getUserLocation provide location coordinates, to get the location name, user would need to user other library, such as react-native-geocoding, with apiKey, to perform the conversion. For this pr, a fixed location is use to mock the conversion implementation.

Notes:

  • Similar to guided search user experience item, may be better if individual page can specify their own layout instead of one layout for entire set of routes in PageRouter.
  • Headless State currently just group every filters and store as a list. To identify and persist the selected options of each filterSearch component when navigating to another page and displaying the same filter searches, user would need to send state through URL, through react-router history/location.state or some shared context. Not too difficult to implement but they are additional steps.
    • This also require some changes to FilterSearch to get the selected filter option and be able to update the initial input
  • Logic that requires input changes (beside initial input) or when to trigger submit to FilterSearch would require copying FilterSearch component and making changes to it. (e.g. a button that gets user location and update filterSearch component input, be able to trigger multiple FilterSearch's setFilterOption call base on a submit button on the page)

J=SLAP-1733
TEST=manual

@yen-tt yen-tt added the use case label Dec 2, 2021
@coveralls
Copy link

coveralls commented Dec 2, 2021

Coverage Status

Coverage remained the same at 71.429% when pulling 05989e7 on dev/nyp-search-experience into 475c4e3 on main.

@yen-tt yen-tt closed this Dec 2, 2021
@yen-tt
Copy link
Contributor Author

yen-tt commented Dec 2, 2021

nyp-search-experience-2.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants