-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add descripiton and keywords to package.json #108
Conversation
"answers", | ||
"yext", | ||
"react", | ||
"components" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did product ask for "components" and "react" here? This library doesn't have any components in it, and also doesn't use react
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably put "redux" here if anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product only gave me one list, but none of the repositories have keywords in package.json. I thought I'd just put the same list, but I was wondering if we need different lists of keywords for all of the repositories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this into main by mistake, but I've reverted the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this PR be merged into develop
instead of main
This reverts commit d4dcbcc.
This PR adds description and keywords to package.json. The description is copied from README and keywords provided by product.
J=SLAP-2190
TEST=manual