add descripiton and keywords to package.json #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannzhou
changed the title
oshi97
approved these changes
Jun 29, 2022
oshi97
reviewed
Jun 29, 2022
| "answers", | ||
| "yext", | ||
| "react", | ||
| "components" |
There was a problem hiding this comment.
Did product ask for "components" and "react" here? This library doesn't have any components in it, and also doesn't use react
There was a problem hiding this comment.
I would probably put "redux" here if anything
There was a problem hiding this comment.
Product only gave me one list, but none of the repositories have keywords in package.json. I thought I'd just put the same list, but I was wondering if we need different lists of keywords for all of the repositories?
There was a problem hiding this comment.
I merged this into main by mistake, but I've reverted the changes.
nmanu1
reviewed
Jun 29, 2022
juliannzhou
added a commit
that referenced
this pull request
Jun 29, 2022
This reverts commit d4dcbcc.
juliannzhou
added a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds description and keywords to package.json. The description is copied from README and keywords provided by product.
J=SLAP-2190
TEST=manual